Implement the --sync flag for df. (fixes #3564) #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add a test. As it is probably too hard to verify that the sync is actually preformed, it will just check that we have a test using the code path |
|
@sylvestre your wish is my command ;) |
|
ah ah, thanks for not being nasty ;) |
there's an issue with dependencies Can you look into it ? I don't know why uucore isn't importing sync from libc. |
The failing builds are on Windows, where |
|
thank you @tertsdiepraam, I'm not a windows dev at all ;) I reused some code from uu_sync to encompass all cases. Is there an available API or function in the uucore librairies to do so ? |
This PR reuses the defined --sync flag for df, which was previously a no-op, assigns its default value and uses the fact that get_all_filesystems takes CLI options as a parameter to perform a sync operation before any fs call. Fixes #3564 Signed-off-by: anastygnome <[email protected]>
It is probably too hard to verify that the sync is actually performed, so we just check that we have a test using the code path, pro forma. Signed-off-by: anastygnome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reuses the defined --sync flag for df, which was previously a
no-op, assigns its default value and uses the fact that
get_all_filesystems takes CLI options as a parameter to perform a sync
operation before any fs call.
Fixes #3564
Signed-off-by: anastygnome [email protected]